Add quic support and fix some bugs #724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerryjiang
reviewed
May 4, 2024
| @@ -97,7 +97,8 @@ private async ValueTask HandleClosing() | |||
| { | |||
| try | |||
| { | |||
| await _pipeTask.ConfigureAwait(false); | |||
| if (_pipeTask != null) | |||
There was a problem hiding this comment.
add comment for the scenario _pipeTask = null
There was a problem hiding this comment.
You can put this change into a separated PR.
kerryjiang
reviewed
May 4, 2024
|
|
||
| namespace SuperSocket.Quic.Connection; | ||
|
|
||
| #pragma warning disable CA2252 |
kerryjiang
reviewed
May 4, 2024
| { | ||
| private readonly Stream _stream; | ||
|
|
||
| public QuicPipeConnection(Stream stream, EndPoint remoteEndPoint, ConnectionOptions options) |
There was a problem hiding this comment.
Does it really accept all kinds of Stream or only support QuicStream?
kerryjiang
reviewed
May 4, 2024
|
|
||
| public async ValueTask OpenStreamAsync(CancellationToken cancellationToken) | ||
| { | ||
| _stream = await _connection.AcceptInboundStreamAsync(cancellationToken); |
There was a problem hiding this comment.
It's inbound stream, do we need handle the outbound stream?
There was a problem hiding this comment.
The Inbound Stream seems to be all that's needed on the server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.